Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix honoring skip phrases #217

Merged
merged 47 commits into from
Mar 12, 2024
Merged

Fix honoring skip phrases #217

merged 47 commits into from
Mar 12, 2024

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif commented Feb 27, 2024

Fixes #214.

  • For push events (applies mostly for main), we rely on if: !contains(github.event.commits[0].message, '[skip *]') to skip the job.
  • For pull_request events, since the commit messages are not available in github context, we rely on a separate step which gets the commit message, and if it contains [skip *], the workflow is 'cancelled' by exit 1.
  • Additionally, I tried to make the Checkout repo/Checkout repo (PR) steps more coherent - in most workflows these steps checkout the head_ref_branch obtained from Get branch names step. This way we ensure that git will always get the commit message from the proper commit.

Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cicdguy cicdguy marked this pull request as ready for review March 4, 2024 14:28
@cicdguy cicdguy requested a review from a team as a code owner March 4, 2024 14:28
Copy link
Contributor

github-actions bot commented Mar 4, 2024

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 4232ae1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit 4232ae1.

♻️ This comment has been updated with latest results.

@walkowif walkowif requested a review from cicdguy March 8, 2024 17:38
Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @walkowif

@walkowif walkowif merged commit a2a7ab0 into main Mar 12, 2024
23 of 24 checks passed
@walkowif walkowif deleted the debug-skip-phrases branch March 12, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [skip roxygen] is not honored when a commit is made with this phrase
2 participants