-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix honoring skip phrases #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Coverage Summary
Diff against main
Results for commit: 4232ae1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary3 tests 3 ✅ 6s ⏱️ Results for commit 4232ae1. ♻️ This comment has been updated with latest results. |
….pkg.template into debug-skip-phrases
This reverts commit 9ac1709.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @walkowif
Fixes #214.
push
events (applies mostly formain
), we rely onif: !contains(github.event.commits[0].message, '[skip *]')
to skip the job.pull_request
events, since the commit messages are not available ingithub
context, we rely on a separate step which gets the commit message, and if it contains[skip *]
, the workflow is 'cancelled' byexit 1
.Checkout repo
/Checkout repo (PR)
steps more coherent - in most workflows these steps checkout thehead_ref_branch
obtained fromGet branch names
step. This way we ensure thatgit
will always get the commit message from the proper commit.